Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip populating destination service host for passthrough and blackhole #16892

Merged
merged 4 commits into from
Sep 9, 2019

Conversation

bianpengyuan
Copy link
Contributor

Also make metric and log entry fall back to request host if destination.service.host is not provided.

#16629 #15255

@bianpengyuan bianpengyuan requested review from a team as code owners September 6, 2019 18:07
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 6, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2019
@bianpengyuan
Copy link
Contributor Author

/test istio-pilot-e2e-envoyv2-v1alpha3-master

@bianpengyuan
Copy link
Contributor Author

cc @nrjpoddar

Copy link
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an e2e that will start passing due to this?

@bianpengyuan
Copy link
Contributor Author

bianpengyuan commented Sep 6, 2019

@mandarjog no, I don't think there is test added yet. I can add one.

@kyessenov
Copy link
Contributor

kyessenov commented Sep 6, 2019

Can you link the issue about what got broken? I was suspicious about setting the attribute for passthrough routes.

Copy link
Member

@nrjpoddar nrjpoddar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should revert changes in config.yaml for TCP metrics.

@nrjpoddar
Copy link
Member

@kyessenov I don't think setting destination.service.host to BlackHole/Passthrough broke anything. This PR makes that field just more useful by making the default more reasonable.

Copy link
Member

@nrjpoddar nrjpoddar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick into release-1.3. Thanks for this PR!

Copy link
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyessenov
Copy link
Contributor

Ok thanks for explaining. I wasn't sure if there is an issue or not.

@nrjpoddar
Copy link
Member

@bianpengyuan is something blocking its merge?

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #16949

brian-avery pushed a commit to brian-avery/istio that referenced this pull request Sep 13, 2019
istio#16892)

* do not populate destination service host for passthrough and blackhole

* fallback to request host in metric and log

* remove request host for tcp

* clean up
@Stono
Copy link
Contributor

Stono commented Sep 25, 2019

Folks should I be expecting this in the current 1.3 release? if so, it doesn't appear to be working:

{destination_app="unknown",destination_service="unknown",destination_service_name="unknown",destination_service_namespace="unknown",destination_version="unknown",destination_workload="unknown",destination_workload_namespace="unknown",instance="10.198.17.85:42422",job="istio-mesh",reporter="source",request_protocol="http",response_code="502",response_flags="-",source_app="sauron-web",source_version="unknown",source_workload="sauron-web",source_workload_namespace="sauron-web"}

@bianpengyuan
Copy link
Contributor Author

bianpengyuan commented Sep 25, 2019

@Stono It is in 1.3.1, and it needs proxy to be upgraded to 1.3.1.

@nrjpoddar
Copy link
Member

nrjpoddar commented Sep 25, 2019

@Stono here's a blog istio/istio.io#5027 I wrote on this topic. The PR will be merged once 1.3.1 is released.

Netlify link might be better for reading: https://deploy-preview-5027--preliminary-istio.netlify.com/blog/2019/monitoring-external-service-traffic/

@Stono
Copy link
Contributor

Stono commented Sep 25, 2019

Thank you :-) looking forward to 1.3.1 then

@Stono
Copy link
Contributor

Stono commented Sep 26, 2019

Confirmed this is working 1.3.1 pre-release #17385

@douglas-reid
Copy link
Contributor

We might need to revisit this in light of the discovery made recently (#18818).

howardjohn added a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants