-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip populating destination service host for passthrough and blackhole #16892
Conversation
/test istio-pilot-e2e-envoyv2-v1alpha3-master |
cc @nrjpoddar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an e2e that will start passing due to this?
@mandarjog no, I don't think there is test added yet. I can add one. |
Can you link the issue about what got broken? I was suspicious about setting the attribute for passthrough routes. |
install/kubernetes/helm/istio/charts/mixer/templates/config.yaml
Outdated
Show resolved
Hide resolved
install/kubernetes/helm/istio/charts/mixer/templates/config.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should revert changes in config.yaml
for TCP metrics.
install/kubernetes/helm/istio/charts/mixer/templates/config.yaml
Outdated
Show resolved
Hide resolved
@kyessenov I don't think setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry-pick into release-1.3. Thanks for this PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ok thanks for explaining. I wasn't sure if there is an issue or not. |
@bianpengyuan is something blocking its merge? |
In response to a cherrypick label: new pull request created: #16949 |
istio#16892) * do not populate destination service host for passthrough and blackhole * fallback to request host in metric and log * remove request host for tcp * clean up
Folks should I be expecting this in the current 1.3 release? if so, it doesn't appear to be working:
|
@Stono It is in 1.3.1, and it needs proxy to be upgraded to 1.3.1. |
@Stono here's a blog istio/istio.io#5027 I wrote on this topic. The PR will be merged once Netlify link might be better for reading: https://deploy-preview-5027--preliminary-istio.netlify.com/blog/2019/monitoring-external-service-traffic/ |
Thank you :-) looking forward to 1.3.1 then |
Confirmed this is working |
We might need to revisit this in light of the discovery made recently (#18818). |
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
Also make metric and log entry fall back to request host if destination.service.host is not provided.
#16629 #15255