Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure mesh.sidecarToTelemetrySessionAffinity with existing helm option #16863

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

mandarjog
Copy link
Contributor

helm option Values.mixer.telemetry.sessionAffinityEnabled has existed for some time. It did not turn on the mesh config flag before. This PR turns the meshconfig flag if Values.mixer.telemetry.sessionAffinityEnabled is specified.

fixes #16862

@mandarjog mandarjog requested a review from a team as a code owner September 5, 2019 23:37
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 5, 2019
@mandarjog
Copy link
Contributor Author

Do we also need to set a pilot variable ?

Copy link
Contributor

@bianpengyuan bianpengyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pilot env variable is 1.1 only, so no need to set anything for pilot.

@mandarjog
Copy link
Contributor Author

/test istio-unit-tests-master

@mandarjog
Copy link
Contributor Author

/test istio-racetest-master

@bianpengyuan
Copy link
Contributor

/test integ-security-k8s-presubmit-tests-master

@istio-testing istio-testing merged commit 130a19c into istio:master Sep 6, 2019
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: #16863 failed to apply on top of branch "release-1.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	install/kubernetes/helm/istio/templates/configmap.yaml
Falling back to patching base and 3-way merge...
Auto-merging install/kubernetes/helm/istio/templates/configmap.yaml
CONFLICT (content): Merge conflict in install/kubernetes/helm/istio/templates/configmap.yaml
Patch failed at 0001 configure sidecarToTelemetrySessionAffinity Values.mixer.telemetry.sessionAffinityEnabled is specified

@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #16897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mixer sidecarToTelemetrySessionAffinity option to old 1.3 installer
6 participants