[release-1.3] Make sd adapter less verbose on server error #16824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
|
/test istio-racetest-release-1.3 |
|
@rlenglet Can you please approve this change to 1.3? Thanks! |
brian-avery
approved these changes
Sep 4, 2019
|
/test istio-racetest-release-1.3 |
rlenglet
approved these changes
Sep 4, 2019
| @@ -166,7 +167,12 @@ func (b *buffered) Send() { | |||
| if err != nil { | |||
| ets := handleError(err, timeSeries) | |||
| b.updateRetryBuffer(ets) | |||
| _ = b.l.Errorf("Stackdriver returned: %v\nGiven data: %v", err, timeSeries) | |||
| b.l.Errorf("%d time series was sent and Stackdriver returned: %v\n", len(timeSeries), err) // nolint: errcheck | |||
There was a problem hiding this comment.
Suggested change
| b.l.Errorf("%d time series was sent and Stackdriver returned: %v\n", len(timeSeries), err) // nolint: errcheck | |
| b.l.Errorf("%d time series were sent and Stackdriver returned: %v", len(timeSeries), err) // nolint: errcheck |
no big deal... 🙂
|
/test e2e-mixer-no_auth-release-1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #16821