Make sd adapter less verbose on server error #16821
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
| @@ -166,7 +166,8 @@ func (b *buffered) Send() { | |||
| if err != nil { | |||
| ets := handleError(err, timeSeries) | |||
| b.updateRetryBuffer(ets) | |||
| _ = b.l.Errorf("Stackdriver returned: %v\nGiven data: %v", err, timeSeries) | |||
| _ = b.l.Errorf("Stackdriver returned: %v\n", err) | |||
There was a problem hiding this comment.
- special case "out of order" and maintain a count of how many data points were rejected.
1a. I hopeerris not a large error message. - It is ok to print other errors.
There was a problem hiding this comment.
It is really not reliable to figure out error type based on message, but it might be ok since it only affects the log output.
Number of points that are affected could be found from error message itself. An example server error message. An example error message: Points must be written in order. One or more of the points specified had an older start time than the most recent point.: timeSeries[12,13,18,19,49,50]
There was a problem hiding this comment.
Added a bit more to the message about total time series sent in RPC.
istio-testing
added
size/S
|
@bianpengyuan: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
In response to a cherrypick label: new pull request created: #16823 |
|
In response to a cherrypick label: new pull request created: #16824 |
fix #16782