Use standard meshconfig defaults in galley #16270
Conversation
googlebot
added
the
cla: yes
istio-testing
added
size/M
|
Do you need to delete galley/pkg/config/meshcfg/defaults.go? |
what... why does galley have two different mesh config defaults?? and they are both wrong? Good catch |
|
Galley had its own defaults because, the alternative was to create yet another dependency on Pilot from Galley. It is used mostly for Ingress handling. It looks like Nathan's refactoring changes allows Galley to depend on the common mesh code now, so removing the defaults now makes sense. Thanks for taking care of this. |
|
Please also update the one in galley/pkg/config as well. That is an off-by-default config processing pipeline. Thanks |
For some reason galley is using its own special MeshConfig, that is different than Helm/what pilot uses, leading to inconsistent config. This changes it to use the standard defaults in pkg/config/mesh.
Makes sense, glad we moved it out then! I just updated the other one. Not sure if it is correct with changes to ingressClass/ingressControllerMode? |
howardjohn
force-pushed
the
galley/normal-default-mesh
branch
from
0d4ef80 to
5546970
Compare
|
/retest |
|
/cherrypick release-1.3 |
|
@rshriram: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test istio-pilot-e2e-envoyv2-v1alpha3-master |
|
/retest |
|
@rshriram: new pull request created: #16361 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For some reason galley is using its own special MeshConfig, that is
different than Helm/what pilot uses, leading to inconsistent config.
This changes it to use the standard defaults in pkg/config/mesh.
[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure