Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AuthorizationPolicy CRD #16187

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

yangminzhu
Copy link
Contributor

@yangminzhu yangminzhu commented Aug 10, 2019

This PR adds the new approved AuthorizationPolicy CRD in pilot and galley.

#12394

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 10, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 10, 2019
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 10, 2019
@yangminzhu yangminzhu force-pushed the authz-api branch 6 times, most recently from c294ae4 to ca10235 Compare August 11, 2019 07:10
@yangminzhu yangminzhu marked this pull request as ready for review August 12, 2019 17:35
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 12, 2019
@yangminzhu
Copy link
Contributor Author

/test istio-racetest-master

@yangminzhu yangminzhu force-pushed the authz-api branch 2 times, most recently from 01837a1 to 17ead63 Compare August 13, 2019 22:51
@yangminzhu
Copy link
Contributor Author

@costinm @nmittler @ozevren @geeknoid Could you take a look of this PR? Thank you.

Copy link
Contributor

@nmittler nmittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine overall. I'm currently in the middle of moving the schemas out of pilot (#16061). Let's hold off on this until that lands (should be today).

Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test upgrade ? New galley with old pilot or old pilot with new galley ?
Usually that's where we had problems.

Also please add a PR for installer, since you're adding roles/CRDs.

@yangminzhu
Copy link
Contributor Author

@costinm I tested upgrading from 1.2.4 and didn't find any problems between pilot and galley. will send out another PR for installer, could you approve this PR if it looks good to you? thanks.

@yangminzhu
Copy link
Contributor Author

/test istio-racetest-master

@istio-testing
Copy link
Collaborator

istio-testing commented Aug 15, 2019

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-new-install-k8s-presubmit-tests-master b1fb8d7 link /test integ-new-install-k8s-presubmit-tests-master
integ-mixer-k8s-presubmit-tests-master b1fb8d7 link /test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu
Copy link
Contributor Author

/test integ-security-k8s-presubmit-tests-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants