-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AuthorizationPolicy CRD #16187
add AuthorizationPolicy CRD #16187
Conversation
c294ae4
to
ca10235
Compare
/test istio-racetest-master |
01837a1
to
17ead63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine overall. I'm currently in the middle of moving the schemas out of pilot (#16061). Let's hold off on this until that lands (should be today).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test upgrade ? New galley with old pilot or old pilot with new galley ?
Usually that's where we had problems.
Also please add a PR for installer, since you're adding roles/CRDs.
@costinm I tested upgrading from 1.2.4 and didn't find any problems between pilot and galley. will send out another PR for installer, could you approve this PR if it looks good to you? thanks. |
/test istio-racetest-master |
@yangminzhu: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test integ-security-k8s-presubmit-tests-master |
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
This PR adds the new approved AuthorizationPolicy CRD in pilot and galley.
#12394
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure