Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing bus factor in CODEOWNERS #16077

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Reducing bus factor in CODEOWNERS #16077

merged 1 commit into from
Aug 6, 2019

Conversation

nmittler
Copy link
Contributor

@nmittler nmittler commented Aug 6, 2019

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@nmittler nmittler requested review from howardjohn and geeknoid August 6, 2019 16:34
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 6, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2019
@rshriram rshriram merged commit 14a0248 into istio:master Aug 6, 2019
@istio-testing
Copy link
Collaborator

@nmittler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-mixer-k8s-presubmit-tests-master 7712b83 link /test integ-mixer-k8s-presubmit-tests-master
integ-new-install-k8s-presubmit-tests-master 7712b83 link /test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshriram rshriram rshriram approved these changes

@howardjohn howardjohn howardjohn approved these changes

@geeknoid geeknoid Awaiting requested review from geeknoid

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nmittler @istio-testing @howardjohn @rshriram @googlebot