Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab latest istio.io/pkg, istio.io/api, and istio.io/common-files #16018

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Grab latest istio.io/pkg, istio.io/api, and istio.io/common-files #16018

merged 1 commit into from
Aug 2, 2019

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Aug 2, 2019

This required a simple change in Galley to stop depending on the
non-existing pkg/annotations package anymore.

This required a simple change in Galley to stop depending on the
non-existing pkg/annotations package anymore.
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 2, 2019
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved labels Aug 2, 2019
@geeknoid geeknoid requested a review from nmittler August 2, 2019 14:51
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, nmittler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid
Copy link
Contributor Author

geeknoid commented Aug 2, 2019

Fixes #16006

@istio-testing istio-testing merged commit fc0f81a into istio:master Aug 2, 2019
@istio-testing
Copy link
Collaborator

@geeknoid: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-new-install-k8s-presubmit-tests-master 0985ad4 link /test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants