Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve "treeNotSorted: not properly sorted" git fsck error #937

Merged
merged 3 commits into from
Nov 25, 2019
Merged

fix: resolve "treeNotSorted: not properly sorted" git fsck error #937

merged 3 commits into from
Nov 25, 2019

Conversation

billiegoose
Copy link
Member

It turns out the proper sort order of config, config0, and config.txt in a Git Tree if config is a directory is:

  • config.txt
  • config
  • config0

because git adds a virtual trailing slash to directory names, and in ASCII ordering . comes before / comes before 0.

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

@isomorphic-git-bot
Copy link

Thank you wmhilton! I auto-formatted the code using prettier-standard. 🤖

@karma-pr-reporter
Copy link

Test Results for 9292df8:

Browser Pass Skip Fail Time Disconnect?
Chrome Mobile 69.0.3497 (Android 7.1.1) 326 1 0 2m:13s false
Edge 17.17134.0 (Windows 10 0.0.0) 326 1 0 3m:45s false
Firefox 70.0.0 (Ubuntu 0.0.0) 326 1 0 1m:41s false
HeadlessChrome 0.0.0 (Linux 0.0.0) 326 1 0 0m:48s false
Mobile Safari 11.0.0 (iOS 11.2.0) 325 2 0 2m:14s false
Safari 11.1.2 (Mac OS X 10.13.6) 326 1 0 3m:24s false

Longest running tests

  • 25.99 secs - fetch fetch --prune-tags from git-http-mock-server - Safari
  • 23.672 secs - fetch fetch (from Github) - Edge
  • 16.645 secs - GitPackIndex to .idx file from .pack - Edge
  • 15.55 secs - fetch fetch --prune-tags from git-http-mock-server - Firefox
  • 15.047 secs - GitPackIndex from .pack - Edge
  • 13.999 secs - fetch shallow fetch (from Github) - Firefox
  • 10.935 secs - fetch shallow fetch (from Github) - Edge
  • 10.558 secs - GitPackIndex to .idx file from .pack - Firefox
  • 10.36 secs - fetch shallow fetch exclude (from Github) - Edge
  • 10.259 secs - fetch shallow fetch since (from Github) - Edge
  • 10.038 secs - GitPackIndex from .pack - Firefox

@billiegoose billiegoose merged commit 74a6905 into master Nov 25, 2019
@billiegoose billiegoose deleted the fix/sortorder branch November 25, 2019 03:33
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelMure MichaelMure mentioned this pull request Oct 24, 2020
Closed
modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
@billiegoose
fix: resolve "treeNotSorted: not properly sorted" git fsck error (iso…
4f0232c 
…morphic-git#937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billiegoose @karma-pr-reporter @isomorphic-git-bot