This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Add sealing key support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Szaknis <m.szaknis@samsung.com>
Signed-off-by: Michał Szaknis <m.szaknis@samsung.com>
|
The modified rsi kernel modules canbe found at https://github.com/islet-project/realm-manager/tree/dev/m.szaknis/key_sealing/realm/linux-rsi |
Havner
approved these changes
Sep 6, 2024
lib/rust-rsi/src/ioctl/kernel.rs
Outdated
| pub(super) realm_sealing_key: [u8; 32] | ||
| } | ||
|
|
||
| impl RsiSealingKey { |
lib/rust-rsi/src/ioctl/kernel.rs
Outdated
|
|
||
| nix::ioctl_read!(abi_version, b'x', 190u8, u64); | ||
| nix::ioctl_readwrite_buf!(measurement_read, b'x', 192u8, RsiMeasurement); | ||
| nix::ioctl_write_buf!(measurement_extend, b'x', 193u8, RsiMeasurement); | ||
| nix::ioctl_readwrite_buf!(attestation_token, b'x', 194u8, RsiAttestation); | ||
| nix::ioctl_readwrite_buf!(sealing_key, b'x', 195u8, RsiSealingKey); |
There was a problem hiding this comment.
Those numbers were take from somewhere, SMCC? They were not random, hence 191 is unused here. Maybe don't use 195, but something higher? Might be wise to find where did I take it from ;-)
tools/rsictl/src/subcmds.rs
Outdated
| @@ -154,3 +154,34 @@ pub(crate) fn verify_platform(args: &VerifyPlatformArgs) -> GenericResult | |||
| tools::verify_print_platform(&token, &key)?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[derive(ValueEnum, Debug, Copy, Clone)] | |||
| pub(crate) enum SealingKeyFlags { | |||
tools/rsictl/src/tools.rs
Outdated
| @@ -49,3 +52,26 @@ pub(crate) fn verify_print_platform(token: &[u8], key: &[u8]) -> Result<(), rust | |||
| rust_rsi::print_token_platform(&token); | |||
| Ok(()) | |||
| } | |||
|
|
|||
| impl From<&SealingKeyFlags> for u64 { | |||
Signed-off-by: Michał Szaknis <m.szaknis@samsung.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for reading key material used in sealing keys derivation.