Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use viewDidLoad over awakeFromNib for KVO init #983

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Use viewDidLoad over awakeFromNib for KVO init #983

merged 1 commit into from
Oct 26, 2020

Conversation

saagarjha
Copy link
Member

This should fix #980, #981.

@saagarjha
Use viewDidLoad over awakeFromNib for KVO init
4ba3852 
awakeFromNib can potentially be called multiple times; in our case twice
because it needs to load the view controller and then the file owner,
which is the view controller again. viewDidLoad is called once.

Also, remove a duplicate segue.
@tbodt tbodt merged commit 0888954 into ish-app:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mysterious crash on tapping "boot this filesystem"
2 participants
@saagarjha @tbodt