Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syscall 136 personality #642

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Add syscall 136 personality #642

merged 3 commits into from
Feb 17, 2020

Conversation

krystophny
Copy link
Contributor

This provides the simple part of fixing #47, as GDB makes system call 136 sys_personality with arguments 0x0000 (set and return value for Linux) and 0xffffffffff (get value). In any other case error code -1 is returned. See http://man7.org/linux/man-pages/man2/personality.2.html

@krystophny krystophny requested a review from tbodt February 17, 2020 14:47
tbodt
tbodt reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@tbodt tbodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks pretty good, just need to return a proper error code.

kernel/getset.c Outdated Show resolved Hide resolved
@tbodt tbodt merged commit 580b3b9 into ish-app:master Feb 17, 2020
@krystophny
Copy link
Contributor Author

Great, thanks for merging. iSH is one of the most amazing pieces of software I've ever seen, so keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbodt tbodt tbodt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystophny @tbodt