Fix pread/pwrite; make read/write be optional #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbodt
reviewed
Jan 12, 2020
saagarjha
force-pushed
the
pread
branch
3 times, most recently
from
a06fbe3 to
97c1ac5
Compare
pread and pwrite have been fixed to return the correct (unchanged) offset. In addition, both functions have been added to fd_ops and sys_read and sys_write will use these if they are available; making them (fd_ops's read/write) effectively optional if there is an implementation of pread and pwrite available. lseek is no longer optional.
This commit is sponsored by Linode. You can use code ish2020 get $20 off your new account. That could be 4 months free on the $5/month plan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written largely in GNU Nano and with minimal testing; in addition to the usual scrutiny I would check formatting if I were you.