Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiwindow #545

Merged
merged 4 commits into from
Nov 4, 2019
Merged

Multiwindow #545

merged 4 commits into from
Nov 4, 2019

Conversation

tbodt
Copy link
Member

@tbodt tbodt commented Oct 28, 2019

This is a pretty big change so I'd like some help testing it before I merge. If you're interested, please build and test this PR and make sure nothing weird or unexpected happens.

cc @NoahPeeters

tbodt and others added 3 commits October 27, 2019 19:29
@tbodt @NoahPeeters
Make the iOS terminal look like a pty
6c906ac 
Also make the terminal and session owned by TerminalViewController.

This is in preparation for scene support.

Co-authored-by: Noah Peeters <noah.peeters@icloud.com>
@tbodt @NoahPeeters
Support multiple windows
6791a15 
Co-authored-by: Noah Peeters <noah.peeters@icloud.com>
@tbodt
Unfocus TerminalView when its window is not key
a5ce352
@tbodt
Copy link
Member Author

tbodt commented Oct 28, 2019

#482

@NoahPeeters
Copy link
Contributor

There seems to be an issue with network io. For example ping 1.1.1.1 gets stuck after the first ping and one cannot stop it with CTRL-C. There is a similar behavior with python -m SimpleHTTPServer. It works until one tries to stop it. But this only happens for processes startet in the ptys. When switching to a default tty with cmd-option-shift-1 it works and it also works in tmux. And ping also seems to work after starting tmux, executing ping and exiting tmux again.

@tbodt
Copy link
Member Author

tbodt commented Nov 2, 2019

@NoahPeeters Fixed that. The signal mask was wrong.

tbodt added a commit that referenced this pull request Nov 4, 2019
@tbodt
Merge pull request #545 from tbodt/multiwindow
64576c8
@tbodt tbodt merged commit 51102d7 into master Nov 4, 2019
@tbodt tbodt deleted the multiwindow branch November 4, 2019 07:01
@Mnpn Mnpn mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbodt @NoahPeeters