Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dockerfile and docker compose #5

Merged
merged 5 commits into from
Dec 25, 2023
Merged

chore: dockerfile and docker compose #5

merged 5 commits into from
Dec 25, 2023

Conversation

LiddleChild
Copy link
Contributor

docker-compose.dev.yaml

  • use docker network
  • remove db and cache ports configuration

Dockerfile
The previous build command does indeed not work like you mentioned. I did that at the very last minute for the sake of decoration and thought it would have the same result as this RUN CGO_ENABLED=0 GOOS=linux go build cmd/main.go.

  • change build command

ImSoZRious
ImSoZRious approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@ImSoZRious ImSoZRious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LiddleChild LiddleChild merged commit 8e00870 into beta Dec 25, 2023
@LiddleChild LiddleChild deleted the devop/dockerfile branch December 25, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImSoZRious ImSoZRious ImSoZRious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiddleChild @ImSoZRious