Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated user section from the README #113

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

jlsjonas
Copy link
Contributor

According to the commit stats of grocy/grocy@27169e1, the underlying issue was released as part of grocy 3.1.0 on Jul 16, 2021.

Unless this is still an ongoing issue with the card, we should remove this section to avoid confusing new users.

Thanks for the great looking card!

@jlsjonas jlsjonas marked this pull request as draft April 27, 2023 12:32
@jlsjonas
Copy link
Contributor Author

I somehow missed the reference from the user_id option during my first read; as the underlying issue should be resolved, what's needed to get it resolved on the card's side?

@isabellaalstrom
Copy link
Owner

Have you tried it from the card now?

@jlsjonas jlsjonas marked this pull request as ready for review April 27, 2023 18:42
@jlsjonas
Copy link
Contributor Author

jlsjonas commented Apr 27, 2023

@isabellaalstrom I've just validated that it works both for adding tasks and checking off chores! 🎉

p.s.: you might want to squash this merge to keep it concise.

@isabellaalstrom
Copy link
Owner

Great, thanks!

@isabellaalstrom isabellaalstrom merged commit def94da into isabellaalstrom:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants