fix: correctly cleanup Array, Raw Vec3, and \*Ref classes

isaac-mason · May 4, 2024 · 365e0aa · 365e0aa
1 parent a86d2c3
commit 365e0aa
Show file tree

Hide file tree

Showing 43 changed files with 685 additions and 249 deletions.
diff --git a/.changeset/few-weeks-jam.md b/.changeset/few-weeks-jam.md
@@ -0,0 +1,7 @@
+---
+"@recast-navigation/core": minor
+"@recast-navigation/wasm": minor
+"recast-navigation": minor
+---
+
+fix: change findPolysAroundCircle resultCost to be a FloatArray, not a FloatRef
diff --git a/.changeset/moody-boats-own.md b/.changeset/moody-boats-own.md
@@ -0,0 +1,6 @@
+---
+"@recast-navigation/core": minor
+"recast-navigation": minor
+---
+
+feat(NavMeshQuery): rename closestPointOnPoly posOverPoly return to isPointOverPoly
diff --git a/.changeset/sharp-maps-relate.md b/.changeset/sharp-maps-relate.md
@@ -0,0 +1,6 @@
+---
+"@recast-navigation/core": minor
+"recast-navigation": minor
+---
+
+feat(Arrays): rename 'free' to 'destroy' for consistency with other methods
diff --git a/.changeset/short-geese-give.md b/.changeset/short-geese-give.md
@@ -0,0 +1,6 @@
+---
+"@recast-navigation/core": minor
+"recast-navigation": minor
+---
+
+fix: missing cleanup for Raw Vec3 and \*Ref classes
diff --git a/apps/navmesh-website/src/features/recast/crowd/recast-agent.tsx b/apps/navmesh-website/src/features/recast/crowd/recast-agent.tsx
@@ -62,10 +62,9 @@ export const RecastAgent = forwardRef<RecastAgentRef, RecastAgentProps>(
         return;
       }
 
-      const navMeshQuery = new NavMeshQuery({ navMesh });
+      const navMeshQuery = new NavMeshQuery(navMesh);
 
-      const crowd = new Crowd({
-        navMesh,
+      const crowd = new Crowd(navMesh, {
         maxAgents: 1,
         maxAgentRadius: agentRadius,
       });

diff --git a/examples/node-cjs-example/index.cjs b/examples/node-cjs-example/index.cjs
@@ -33,7 +33,7 @@ Recast.init().then(() => {
 
   const { navMesh } = RecastGenerators.generateSoloNavMesh(positions, indices, config);
 
-  const navMeshQuery = new Recast.NavMeshQuery({ navMesh });
+  const navMeshQuery = new Recast.NavMeshQuery(navMesh);
 
   const { point: closestPoint } = navMeshQuery.findClosestPoint({ x: 2, y: 1, z: 2 });
 

diff --git a/examples/node-esm-example/index.mjs b/examples/node-esm-example/index.mjs
@@ -34,7 +34,7 @@ const indices = groundMesh.geometry.index.array;
 
 const { navMesh } = generateSoloNavMesh(positions, indices, config);
 
-const navMeshQuery = new NavMeshQuery({ navMesh });
+const navMeshQuery = new NavMeshQuery(navMesh);
 
 const { point: closestPoint } = navMeshQuery.findClosestPoint({ x: 2, y: 1, z: 2 });
 

diff --git a/examples/vite-example/src/app.tsx b/examples/vite-example/src/app.tsx
@@ -39,7 +39,7 @@ const App = () => {
 
     if (!success) return;
 
-    const navMeshQuery = new NavMeshQuery({ navMesh });
+    const navMeshQuery = new NavMeshQuery(navMesh);
 
     const navMeshHelper = new NavMeshHelper({
       navMesh,

diff --git a/packages/recast-navigation-core/src/arrays.ts b/packages/recast-navigation-core/src/arrays.ts
@@ -49,8 +49,8 @@ abstract class BaseArray<
     view.set(data);
   }
 
-  free() {
-    this.raw.free();
+  destroy() {
+    Raw.destroy(this.raw);
   }
 
   getHeapView(): InstanceType<T> {