Use httplib #5
Merged
Use httplib #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2012 12:11
Works on App Engine, tests pass
Seemed kind of weird to have a headers instance field in IronMQ. Default arguments should not be mutable since it can lead to easy mistakes. Also got rid of __setCommonHeaders function in favor of a "constant".
|
Passes my tests, looks good to me. (Much improved structuring, by the way. Awesome.) I'll port these changes over to iron_worker_python. At some point, I'll have to come up with a better way to test App Engine integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.