Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new file browser view with table sort #775

Merged
merged 27 commits into from
Jan 9, 2025
Merged

new file browser view with table sort #775

merged 27 commits into from
Jan 9, 2025

Conversation

achen5671
Copy link
Contributor

@achen5671 achen5671 commented Dec 6, 2024

Summary

https://tsu.atlassian.net/browse/IR-5813

Subtasks Checklist

SORTING & NEW TABLE COLUMNS

Screenshot 2025-01-07 at 3 29 56 PM

NEW FILEITEMS UI

Screenshot 2025-01-07 at 3 31 16 PM

Screenshot 2025-01-07 at 3 31 46 PM

Breaking Changes

References

closes #insert number here

QA Steps

@DanielBelmes DanielBelmes self-requested a review December 9, 2024 20:38
Copy link
Contributor

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to sync the dev and design here

image

image

@aditya-mitra
Copy link
Contributor

the tooltip works great. if we could add it below the file name instead of above, it would look nicer.

image

@achen5671
Copy link
Contributor Author

we will need to sync the dev and design here

image

image

are we referring to the data that is being display on the table?

@achen5671 achen5671 requested a review from aditya-mitra January 7, 2025 18:44
@achen5671 achen5671 changed the title [iR-5813] polish file browser view [iR-5813] New file browser view with table sort Jan 7, 2025
@aditya-mitra aditya-mitra changed the title [iR-5813] New file browser view with table sort new file browser view with table sort Jan 8, 2025
Copy link
Contributor

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very well written and good detailing!

found a bug that we need to solve:

when the statistics column is sorted, an error is thrown at filebrowser.tsx:123

2025-01-08.at.18.11.51.mp4

@achen5671
Copy link
Contributor Author

very well written and good detailing!

found a bug that we need to solve:

when the statistics column is sorted, an error is thrown at filebrowser.tsx:123

2025-01-08.at.18.11.51.mp4

thanks for the catch! this is fixed

@achen5671 achen5671 requested a review from aditya-mitra January 8, 2025 15:09
Copy link
Contributor

@aditya-mitra aditya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🟢

@achen5671 achen5671 added this pull request to the merge queue Jan 9, 2025
Merged via the queue into dev with commit 22fc2e4 Jan 9, 2025
24 checks passed
@achen5671 achen5671 deleted the ac-ir-5813 branch January 9, 2025 15:52
heysokam pushed a commit that referenced this pull request Jan 14, 2025
* reformat file

* rename view components

* table view border and colors

* add hover

* file card polish

* refactor fileicon component

* add tags

* fix style for grid card

* fix asset card style

* style fixes

* fix minifed image

* cleanup fileicon with thumbnails

* fix assets file icons

* add additional data to file table

* update tooltip posiiton to bottom

* sort table

* fix lint

* fix crashing on undefined table values

* ts lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants