This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: add buffer and cleanup #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update deps - lint fixes - add buffer - fix tiered open - fix tiered `has`, fail test added also
56 tasks
achingbrain
suggested changes
Apr 2, 2020
| } | ||
| })) | ||
| async has (key) { | ||
| for (const s of this.stores) { |
There was a problem hiding this comment.
Maybe Promise.race here? The previous code looked through all nested stores in parallel, this makes it serial but it should never have waited for them all to complete before resolving to a value.
There was a problem hiding this comment.
race is weird (http://bluebirdjs.com/docs/api/promise.race.html), with https://github.com/sindresorhus/p-any we would need to try catch twice to return a boolean.
do you think its worth it ? this looks nice and simple
There was a problem hiding this comment.
The semantics are a little convoluted. Let's merge this then we can look at refactoring it if it proves to be a bottleneck.
achingbrain
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has, fail test added also