Fix crate vendoring to not run the default fixup phase
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixup phase will move things around, for example, if the source directory happens to have a directory named `doc` it will get moved under `$out/share`. Generally speaking, there shouldn't be anything to fixup since this is just a 1-1 unpacking of the source tarball (with the addition of a checksum file)
The fixup phase will move things around, for example, if the source directory happens to have a directory named `doc` it will get moved under `$out/share`. Generally speaking, there shouldn't be anything to fixup since this is just a 1-1 unpacking of the source tarball (with the addition of a checksum file)
Unpacking in the current directory means we end up installing extra things managed by the build environment (like the `env-vars` file). Unpacking to a fresh directory (and then changing the source root) before installing avoids this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #618
Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md