Remove unnecessary delete() in sync_timing.py #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
the delete() is actually necessary at the moment due to the kernel bug in the update() that was introduced in May and bugfix wasn't merged yet. |
|
Link to bugfix? Also, in that case, @pchaigno could you update this PR to be a comment mentioning the reason for the extra .delete(). |
|
Thanks for the explanation @4ast! @drzaeus77 I'm on it! |
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a6ed3ea65d9868fdf9eff84e6fe4f666b8d14b02 |
This delete() is required because of a kernel bug: https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a6ed3ea65d9868fdf9eff84e6fe4f666b8d14b02
pchaigno
force-pushed
the
sync_timing-delete
branch
from
bc67051 to
1c41529
Compare
|
Pull request updated! |
chantra
pushed a commit
to chantra/bcc
that referenced
this pull request
Sep 16, 2016
This delete() is required because of a kernel bug: https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a6ed3ea65d9868fdf9eff84e6fe4f666b8d14b02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes an unnecessary
.delete(&key)insync_timing.pyand updates the tutorial accordingly.