Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/cpudist: Add extension summary support #4131

Merged
merged 2 commits into from
Jul 29, 2022
Merged

tools/cpudist: Add extension summary support #4131

merged 2 commits into from
Jul 29, 2022

Conversation

xingfeng2510
Copy link
Contributor

@xingfeng2510 xingfeng2510 commented Jul 25, 2022 •
edited
Loading

Sometimes, I want to known total on-CPU or off-CPU time and count (same as context switch times) at a fixed interval (for example: 1s).

Like #3384, This patch try to add an option -e to show extension summary (average/total/count).

# ./cpudist.py -p $(pgrep -nx mysqld) -e 1

     usecs               : count     distribution
         0 -> 1          : 4123     |**************                          |
         2 -> 3          : 11690    |****************************************|
         4 -> 7          : 1668     |*****                                   |
         8 -> 15         : 859      |**                                      |
        16 -> 31         : 618      |**                                      |
        32 -> 63         : 290      |                                        |
        64 -> 127        : 247      |                                        |
       128 -> 255        : 198      |                                        |
       256 -> 511        : 161      |                                        |
       512 -> 1023       : 370      |*                                       |
      1024 -> 2047       : 98       |                                        |
      2048 -> 4095       : 6        |                                        |
      4096 -> 8191       : 16       |                                        |

avg = 33 usecs, total: 682091 usecs, count: 20383

@yonghong-song Please take a look, thanks.

@xingfeng2510 xingfeng2510 force-pushed the fixup branch 4 times, most recently from d9fc74f to bf768c7 Compare July 25, 2022 13:16
@yonghong-song
Copy link
Collaborator

LGTM. The implementation is very similar to biolatency.py.

@yonghong-song yonghong-song merged commit 4a60443 into iovisor:master Jul 29, 2022
chenhengqi added a commit to chenhengqi/bcc that referenced this pull request Aug 6, 2022
@chenhengqi
tools/cpudist: Fix warning introduced by recent change
86bf109 
With iovisor#4131 included, running the tool with -L reports the following warning:

    /virtual/main.c:57:28: warning: multi-character character constant [-Wmultichar]
        pid_key_t key = {.id = ' + pid + ', .slot = bpf_log2l(delta)};
                               ^
    /virtual/main.c:57:28: warning: character constant too long for its type
    2 warnings generated.

The `pid` part should not be treated as string literal. Fix it.

Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
@chenhengqi chenhengqi mentioned this pull request Aug 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendangregg brendangregg Awaiting requested review from brendangregg brendangregg is a code owner

@goldshtn goldshtn Awaiting requested review from goldshtn goldshtn is a code owner

@davemarchevsky davemarchevsky Awaiting requested review from davemarchevsky davemarchevsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xingfeng2510 @yonghong-song