Add BPF python helpers for reading trace_pipe #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brenden Blanco <bblanco@plumgrid.com>
4ast
pushed a commit
that referenced
this pull request
Aug 21, 2015
Add BPF python helpers for reading trace_pipe
|
Sorry to overload, but here's 3 small suggestions:
# python3 syncsnoop
TIME(s) CALL
Traceback (most recent call last):
File "syncsnoop", line 33, in <module>
line = b.trace_readline()
File "/usr/lib/python3/dist-packages/bpf/__init__.py", line 422, in trace_readline
trace = BPF.trace_open(nonblocking)
File "/usr/lib/python3/dist-packages/bpf/__init__.py", line 409, in trace_open
fd = trace.fileno()
NameError: name 'trace' is not defined
try:
line = b.trace_readline()
except KeyboardInterrupt:
pass; exit()So we can just call b.trace_readline(). This means a Ctrl-C will always exit() the program if you are using trace_readline(). I think this is desirable, since the signal means a human has hit Ctrl-C, and the common expected behavior would be to exit. (This exception handling should be the same with #149 as well). It'll save some boilerplate in many common scripts.
# ../examples/hello_world.py
bash-14044 [001] d... 29450763.501397: : Hello, World!
^CTraceback (most recent call last):
File "../examples/hello_world.py", line 19, in <module>
b.trace_print()
File "/usr/lib/python2.7/dist-packages/bpf/__init__.py", line 435, in trace_print
line = BPF.trace_readline(nonblocking=False)
File "/usr/lib/python2.7/dist-packages/bpf/__init__.py", line 427, in trace_readline
except BlockingIOError:
NameError: global name 'BlockingIOError' is not defined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brenden Blanco bblanco@plumgrid.com