Move BCC debug options to a installed header file #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtenor
requested review from
4ast,
drzaeus77,
goldshtn and
yonghong-song
as code owners
palmtenor
force-pushed
the
enum_header
branch
from
9351877 to
73e2f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BCC debug options are defined in
common.h, which is not an installed header. Thus, if user want to use those options, they'll need to inspect the code and manually pass the integer value toBPForBPFModuleconstructor.This commit moves the options to
bpf_module.hwhich is installed. Also fix the silly mistake I made in #1436 thatDEBUG_BPF_REGISTER_STATEwas defined to be0x16rather than just16(0x10).