Exit on EPIPE #1393
Exit on EPIPE #1393
Conversation
| if e.errno == errno.EPIPE: | ||
| exit() | ||
| else: | ||
| raise e |
There was a problem hiding this comment.
The callback function can be arbitrary user function here. Why you single out EPIPE errno from
another other exceptions?
There was a problem hiding this comment.
If the developer makes a mistake in his callback function (say, write to a file on which she doesn't have permissions), we want to display the usual traceback, no?
There was a problem hiding this comment.
Any exception should already have a traceback here?
There was a problem hiding this comment.
Yes. If I exit on every exception (or ignore some), these tracebacks won't be displayed.
There was a problem hiding this comment.
So why the exit for errno.EPIPE? If you have an example of callback function and/or lost_cb function, probably it is easier to try and understand your point?
There was a problem hiding this comment.
The goal is to properly exit when receiving EPIPE or SIGPIPE as described in #1010.
If you take the example from #1010, when running ./opensnoop.py | head, it will display 10 lines then exception tracebacks for each new line without exiting because of the EPIPE Exception. With the present pull request it will properly exit (call cleanup and not display a traceback) on the first EPIPE Exception.
Fixes #1010.
/cc @brendangregg