Fix 'tools/syscount' from using incorrect fallback values #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents 'tools/syscount' from using incorrect system call descriptions if the 'ausyscall' command is not found. In this case, it uses a lookup table as a fallback. This, however, is compliant with x86_64 only. For now, we fix this by raising an exception and exiting if the 'ausyscall' executable is not available for non-x86_64 systems instead of having additional lookup tables for other architectures. Signed-off-by: Sandipan Das <sandipan@linux.vnet.ibm.com>
|
ok, thanks, makes sense for now. |
|
[buildbot, ok to test] |
2 similar comments
|
[buildbot, ok to test] |
|
[buildbot, ok to test] |
|
@drzaeus77 could you help check buildbot issue? it seems not responding (at least publicly)? |
|
Taking a look now...a couple days ago I updated packages and jenkins plugins, as well as rebooted it. It was stuck in some weird state where the bcc-pr job was not spawning slaves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
tools/syscountfrom using incorrect system call names if the 'ausyscall' command is not found. This is because it does not come pre-installed in all distros. In this case, it uses a lookup table as a fallback but this table is usable forx86_64only. For now, we fix this by raising an exception and exiting if theausyscallexecutable is not available for non-x86_64systems instead of having additional lookup tables for other architectures.