Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdflush: fix for Linux 4.14 #1384

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Oct 8, 2017

Starting Linux 4.14, there's one less indirection layer to get the
disk name.

@yonghong-song
Copy link
Collaborator

This probably will not work with backported distribution (fb internal, netflix internal, certain redhat dist.) I am not sure what is the standard way to deal with this.

cc @brendangregg

@brendangregg
Copy link
Member

So far we've gotten away with checking if symbols exist rather than kernel versions. But in this case it's a structure difference. I wonder if there's a symbol change from the same patchset we could use as an indicator?

In any case, this should be commented to say that it's temporary code. "# workaround for the 4.14 change." That way, we can find it in the distant future and delete it when it's no longer needed.

Starting Linux 4.14, there's one less indirection layer to get the
disk name. Use the bio_dev macro to discriminate between versions.
@pchaigno pchaigno force-pushed the fix-mdflush-linux-4.14 branch from 8b9cf2d to 3ffc80e Compare October 23, 2017 19:27
@pchaigno
Copy link
Contributor Author

pchaigno commented Oct 24, 2017

I hadn't though about backported distributions.
I've updated the pull request to use the bio-dev macro as a discriminator to detect the structure difference. That macro was introduced in the same commit as the structure change.

@drzaeus77 Could you relaunch the build? Looks like it failed due to the certificate expiration. Never mind, it started when I commented 😮

@yonghong-song
Copy link
Collaborator

LGTM. I think this addressed Brendan's concern.

@yonghong-song yonghong-song merged commit 16f201f into iovisor:master Oct 27, 2017
@pchaigno pchaigno deleted the fix-mdflush-linux-4.14 branch October 27, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants