-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter cleanups #1383
Linter cleanups #1383
Conversation
Paddin my ignorance, what would we gain by having Travis CI build this repository? We already have three Jenkins build bots. |
Paddin = pardon, silly phone :) |
I'm 👍 with having this as part of the Jenkins' pipeline. I initially went for Travis CI (proposed in #920, added in #987) because, contrary to the other tests, lint checks should not depend on the underlying OS version and we thus don't need to start a VM; a Travis container is faster. I also really appreciate the integration with GitHub. In particular, the configuration is part of the source code, which doesn't seem to be the case for the current Jenkins build bots. |
/cc @drzaeus77 I have good experience with TravisCI, just a bit worried about the duplication. If it's only going to be used as a linter, I think it doesn't hurt -- it does provide very fast build feedback unlike the current build bots, and requires no additional maintenance on our part. |
LGTM. Merge ready? cc @drzaeus77 |
Without Travis-CI (or some other CI) enabled, we'll probably have to do this again in a few weeks... |
Would it be possible to enable Travis CI for the repo before merging this pull request?