execsnoop: Fix -x handling #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execsnoop's documentation says -x/--fails means "also include failed exec()s". However it was programmed to instead skip successful execs on -x and without -x show all - successful and unsuccessful ones. The logic was broken in 5b47e0f ("execsnoop: use BPF_PERF_OUTPUT instead of trace pipe"). Fix it. P.S. current test_tools_smoke.py only provides basic infrastructure for testing whether tool's BPF program won't break, without anything related to options handling, so unfortunately the patch comes without corresponding test.
|
[buildbot, ok to test] |
|
@brendangregg Could you please take a look? |
|
( Ubuntu Jenkins failure is probably due to some git/networking glitch: https://buildbot.iovisor.org/jenkins/job/bcc-pr/645/label=ubuntu1604/console, not this patch; builds on fc24 and fc25 succeeded ) |
|
Yeah, we need to feed the buildbot. @drzaeus77 |
|
ping @brendangregg, @drzaeus77, @goldshtn |
|
thanks, this fixes it! |
|
[buildbot, ok to test] |
|
... I would merge this, but my merge button is greyed out since the build failed. Gotta fix the build first. |
|
[buildbot, test this please] |
|
Everyone thanks for feedback & action. It is now all green. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execsnoop's documentation says -x/--fails means "also include failed
exec()s". However it was programmed to instead skip successful execs on
-x, and without -x shows all - successful and unsuccessful ones.
The logic was broken in 5b47e0f ("execsnoop: use BPF_PERF_OUTPUT
instead of trace pipe").
Fix it.
P.S. current test_tools_smoke.py only provides basic infrastructure for
testing whether tool's BPF program won't break, without anything related
to options handling, so unfortunately the patch comes without
corresponding test.
/cc @brendangregg, @markdrayton