Remove unnecessary bpf_probe_reads #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of a kernel function to cast sk is masking the assignment of the external pointer to the bcc rewriter and prevents subsequent use of dereferences.
drzaeus77
approved these changes
Aug 22, 2017
|
tested, works, thanks. Much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on improving bcc's rewriting of dereferences, I found a few tools that use
bpf_probe_reads where bcc already support deferences.I tested that the three tools still work as expected on both IPv4 and IPv6 connections.
Note: The same applies to several tools in
tools/old/, but I wasn't sure we're supposed to change those.