-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code structure refactor #5582
Code structure refactor #5582
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
@SchrodingersGat I can not find any usage of these CI checks:
|
These are both outdated now:
|
@matmair in general this looks OK - what still to do? Any additional unit tests we would need to add? |
@SchrodingersGat not really, I still need to add docs - should be good to go end of week. |
…matmair/issue5578
@matmair I have made some tweaks so that the devcontainer works again |
- Set INVENTREE_BACKEND_DIR separately
Ok this seems to work with docker and devcontainer - the documentation issues are because of the already adapted github source links. Happy for another review; this has been very long running so not sure if I have missed something. Thank you for the help @SchrodingersGat |
Do we need to keep the empty |
In my tests the packaging mechanism stopped detecting that the project uses python if I removed it. |
@matmair I have reviewed locally again and it all seems to be working well. I will merge this in, however we should all be on the lookout for any issues stemming from this. This is a huge change to the codebase so there may well be problems. The |
@SchrodingersGat I expect some small surprises but most bases should be covered with the CI tests |
* fix tests after code structure refactor of the inventree source (related to inventree/InvenTree#5582)
This PR implements #5578 and reorganises the code base more scalable. This is the first PR in a string of PRs needed, see #5578.
closes #5578
Breaking Change
This is a significant breaking change as it rearranges a lot of source files. Any developers who are using the devcontainer setup will need to do a complete rebuild (without cache) of the devcontainer.