This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Fixes #1614 - Protect cleanup code of plugin unload #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmigottipati
force-pushed
the
fix-cleanup
branch
from
5f53a52 to
8da22ea
Compare
jcooklin
reviewed
Apr 27, 2017
| @@ -582,22 +590,32 @@ func (p *pluginManager) UnloadPlugin(pl core.Plugin) (*loadedPlugin, serror.Snap | |||
| "plugin-version": plugin.Version(), | |||
| "plugin-path": plugin.Details.Path, | |||
| }).Debugf("Removing plugin") | |||
| if err := os.RemoveAll(filepath.Dir(plugin.Details.Path)); err != nil { | |||
| if strings.Contains(plugin.Details.Path, p.tempDirPath) { | |||
jcooklin
reviewed
Apr 27, 2017
control/plugin_manager.go
Outdated
| "plugin-path": plugin.Details.Path, | ||
| }) | ||
| return nil, se | ||
| }).Info("Nothing to delete as temp path is empty") |
There was a problem hiding this comment.
Let's change this to a debug message.
jcooklin
approved these changes
Apr 27, 2017
rashmigottipati
force-pushed
the
fix-cleanup
branch
from
d9fa46e to
9f64383
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1614
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers