This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Makes plugin healthchecks less aggressive #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lengthens the timeout for plugin health checks in order to be less aggressive about killing plugins.
|
@IRCody The code looks ok. I'm just wondering what is the root cause of this change. Have you run some performance or stability testing? |
|
@andrzej-k there have been reports that systems under (significant) load were not able to respond to the health check in-time. |
andrzej-k
approved these changes
Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
-Lengthens the timeout for plugin health checks in order to be less
aggressive about killing plugins.
@intelsdi-x/snap-maintainers