Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Change graph cleanup environment variable name #8720

Merged
merged 3 commits into from
Mar 28, 2023
Merged

[SYCL] Change graph cleanup environment variable name #8720

merged 3 commits into from
Mar 28, 2023

Conversation

sergey-semenov
Copy link
Contributor

Now that there's only one regular graph cleanup mechanism, there's no need for two environment variables. Change it to SYCL_DISABLE_EXECUTION_GRAPH_CLEANUP and deprecate SYCL_DISABLE_POST_ENQUEUE_CLEANUP.

@sergey-semenov
[SYCL] Change graph cleanup environment variable name
3589598 
Now that there's only one regular graph cleanup mechanism, there's
no need for two environment variables. Change it to
SYCL_DISABLE_EXECUTION_GRAPH_CLEANUP and deprecate
SYCL_DISABLE_POST_ENQUEUE_CLEANUP.
@sergey-semenov sergey-semenov requested review from a team as code owners March 21, 2023 16:09
AlexeySachkov
AlexeySachkov approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM

@sergey-semenov sergey-semenov temporarily deployed to aws March 21, 2023 19:52 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 22, 2023 00:25 — with GitHub Actions Inactive
bso-intel
bso-intel approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steffenlarsen
steffenlarsen approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergey-semenov sergey-semenov temporarily deployed to aws March 27, 2023 16:59 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 27, 2023 18:14 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov merged commit 8a435d4 into intel:sycl Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@bso-intel bso-intel bso-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergey-semenov @bso-intel @AlexeySachkov @steffenlarsen