[Doc] Remove unused SPV_INTEL_non_constant_addrspace_printf extension #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support of this extension was removed from translator in favor of Khronos extension in KhronosGroup/SPIRV-LLVM-Translator@ac7a7596 As long as it was never used in compiler pipeline, the design can be removed. Specification of SPV_EXT_relaxed_printf_string_address_space: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/EXT/SPV_EXT_relaxed_printf_string_address_space.asciidoc Signed-off-by: Maksimova, Viktoria <viktoria.maksimova@intel.com>
|
Should we also remove the reserved tokens from token-registry.asciidoc, making them available to other extensions? |
Good catch, thanks! I'll remove the token from the registry too. |
MrSidims
approved these changes
Feb 9, 2023
|
@intel/dpcpp-spirv-doc-reviewers could you please take a look? |
AlexeySachkov
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of this extension was removed from translator in favor of Khronos extension in KhronosGroup/SPIRV-LLVM-Translator@ac7a7596 As long as it was never used in compiler pipeline, the design can be removed.
Specification of SPV_EXT_relaxed_printf_string_address_space: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/EXT/SPV_EXT_relaxed_printf_string_address_space.asciidoc
Signed-off-by: Maksimova, Viktoria viktoria.maksimova@intel.com