[SYCL] Reorder enum read_write_mode
#8248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spec change is OK. Note that this is an ABI break. We allow ABI breaks for "experimental" features, so this is not a showstopper, though. I see that the specification is in the "proposed" directory, but it seems like there is also some implementation. Is this extension fully implemented at this point? Is it being used? If so, it should be moved to "experimental". |
gmlueck
approved these changes
Feb 8, 2023
dm-vodopyanov
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Approved, provided that @gmlueck question above will be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder
read_write_mode_enumto be consistent with SPIR-V Access Qualifier