Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][DOC] Move SPIR-V and OpenCL extensions #5578

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Feb 15, 2022

The SPIR-V and OpenCL extensions are not SYCL extensions, rather they
are extensions to underlying components used by DPC++. Therefore, we
consider them part of the design, so move them to "doc/design".

Our policy is to remove SPIR-V and OpenCL extension specifications from
this repo once they are added to the Khronos registry. The
"SPV_INTEL_arbitrary_precision_int" extension was already added there,
so remove it from this repo.

The SPIR-V and OpenCL extensions are not SYCL extensions, rather they
are extensions to underlying components used by DPC++.  Therefore, we
consider them part of the design, so move them to "doc/design".

Our policy is to remove SPIR-V and OpenCL extension specifications from
this repo once they are added to the Khronos registry.  The
"SPV_INTEL_arbitrary_precision_int" extension was already added there,
so remove it from this repo.
@gmlueck gmlueck requested review from a team as code owners February 15, 2022 18:23
bader
bader previously approved these changes Feb 15, 2022
sycl/doc/extensions/README.md Show resolved Hide resolved
bashbaug
bashbaug previously approved these changes Feb 15, 2022
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bader
Copy link
Contributor

bader commented Feb 16, 2022

@gmlueck, please, fix "Generate Doxygen documentation" job.

Do not generate Sphinx documentation for the OpenCL or SPIR-V
extensions because they are written in AsciiDoc, which Spinx does not
support well.  Instead, link to their GitHub location, and readers can
read GitHub's rendering of the AsciiDoc documents.  This is the same
thing we do already for the SYCL extension specifications.
@gmlueck gmlueck dismissed stale reviews from bashbaug and bader via 94c0211 February 16, 2022 13:30
@gmlueck
Copy link
Contributor Author

gmlueck commented Feb 16, 2022

@gmlueck, please, fix "Generate Doxygen documentation" job.

Done in 94c0211

@gmlueck
Copy link
Contributor Author

gmlueck commented Feb 17, 2022

@bader: Can this be merged?

@bader bader merged commit 64e92cb into intel:sycl Feb 17, 2022
@gmlueck gmlueck deleted the gmlueck/mv-spirv-opencl-extensions branch February 17, 2022 17:21
smaslov-intel pushed a commit to smaslov-intel/llvm that referenced this pull request Feb 19, 2022
The SPIR-V and OpenCL extensions are not SYCL extensions, rather they
are extensions to underlying components used by DPC++.  Therefore, we
consider them part of the design, so move them to "doc/design".

Our policy is to remove SPIR-V and OpenCL extension specifications from
this repo once they are added to the Khronos registry.  The
"SPV_INTEL_arbitrary_precision_int" extension was already added there,
so remove it from this repo.
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Feb 23, 2022
* upstream/sycl: (2757 commits)
  [SYCL][Doc] Fixing incorrect merge of community Readme.md with our version (intel#5636)
  [SYCL] Change USM pooling parameters. (intel#5457)
  [CI] Fix cache location on Windows (intel#5603)
  [SYCL][NFC] Fix a warning about uninitialized struct members (intel#5610)
  [Buildbot] Update Windows GPU version to 101.1340 (intel#5620)
  Fix SPIRV -> OCL barrier call argument attributes
  Move SPV_INTEL_memory_access_aliasing tokens from spirv_internal
  [SYCL][ESIMD] Add support for named barrier APIs (intel#5583)
  [SYCL][L0] Remove ZeModule when program build failed (intel#5541)
  [SYCL] Silence "unknown attribute" warning for `device_indirectly_callable` (intel#5591)
  [SYCL][DOC] Introductory material for extensions (intel#5605)
  [SYCL][DOC] Change extension names to lower case (intel#5607)
  [SYCL] Improve get_kernel_bundle performance (intel#5496)
  [SYCL] Do not build device code for sub-devices (intel#5240)
  [sycl-post-link] Fix a crash during spec-constant properties generation (intel#5538)
  [SYCL][DOC] Move SPIR-V and OpenCL extensions (intel#5578)
  [SYCL][ESIMD][EMU] Update memory intrinsics for ESIMD_EMU plugin (intel#4748)
  [CI] Allow stale issue bot to analyze more issues (intel#5602)
  [SYCL][L0] Honor property::queue::enable_profiling (intel#5543)
  [OpenMP] Properly save strings when doing LTO
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants