-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][DOC] Move SPIR-V and OpenCL extensions #5578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SPIR-V and OpenCL extensions are not SYCL extensions, rather they are extensions to underlying components used by DPC++. Therefore, we consider them part of the design, so move them to "doc/design". Our policy is to remove SPIR-V and OpenCL extension specifications from this repo once they are added to the Khronos registry. The "SPV_INTEL_arbitrary_precision_int" extension was already added there, so remove it from this repo.
bader
previously approved these changes
Feb 15, 2022
bashbaug
previously approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gmlueck, please, fix "Generate Doxygen documentation" job. |
Do not generate Sphinx documentation for the OpenCL or SPIR-V extensions because they are written in AsciiDoc, which Spinx does not support well. Instead, link to their GitHub location, and readers can read GitHub's rendering of the AsciiDoc documents. This is the same thing we do already for the SYCL extension specifications.
jbrodman
approved these changes
Feb 17, 2022
@bader: Can this be merged? |
smaslov-intel
pushed a commit
to smaslov-intel/llvm
that referenced
this pull request
Feb 19, 2022
The SPIR-V and OpenCL extensions are not SYCL extensions, rather they are extensions to underlying components used by DPC++. Therefore, we consider them part of the design, so move them to "doc/design". Our policy is to remove SPIR-V and OpenCL extension specifications from this repo once they are added to the Khronos registry. The "SPV_INTEL_arbitrary_precision_int" extension was already added there, so remove it from this repo.
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Feb 23, 2022
* upstream/sycl: (2757 commits) [SYCL][Doc] Fixing incorrect merge of community Readme.md with our version (intel#5636) [SYCL] Change USM pooling parameters. (intel#5457) [CI] Fix cache location on Windows (intel#5603) [SYCL][NFC] Fix a warning about uninitialized struct members (intel#5610) [Buildbot] Update Windows GPU version to 101.1340 (intel#5620) Fix SPIRV -> OCL barrier call argument attributes Move SPV_INTEL_memory_access_aliasing tokens from spirv_internal [SYCL][ESIMD] Add support for named barrier APIs (intel#5583) [SYCL][L0] Remove ZeModule when program build failed (intel#5541) [SYCL] Silence "unknown attribute" warning for `device_indirectly_callable` (intel#5591) [SYCL][DOC] Introductory material for extensions (intel#5605) [SYCL][DOC] Change extension names to lower case (intel#5607) [SYCL] Improve get_kernel_bundle performance (intel#5496) [SYCL] Do not build device code for sub-devices (intel#5240) [sycl-post-link] Fix a crash during spec-constant properties generation (intel#5538) [SYCL][DOC] Move SPIR-V and OpenCL extensions (intel#5578) [SYCL][ESIMD][EMU] Update memory intrinsics for ESIMD_EMU plugin (intel#4748) [CI] Allow stale issue bot to analyze more issues (intel#5602) [SYCL][L0] Honor property::queue::enable_profiling (intel#5543) [OpenMP] Properly save strings when doing LTO ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SPIR-V and OpenCL extensions are not SYCL extensions, rather they
are extensions to underlying components used by DPC++. Therefore, we
consider them part of the design, so move them to "doc/design".
Our policy is to remove SPIR-V and OpenCL extension specifications from
this repo once they are added to the Khronos registry. The
"SPV_INTEL_arbitrary_precision_int" extension was already added there,
so remove it from this repo.