[SYCL][DOC] Fix some more documentation links #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two more documentation links. The links to "PropertyList/SYCL_EXT_ONEAPI_property_list.asciidoc" were wrong even before my recent reorg because the document used to be called "SYCL_EXT_ONEAPI_properties.asciidoc". The links to "StaticLocalMemoryQuery/SYCL_INTEL_static_local_memory_query" were somehow missed from eb350ee. The "USM/README.md" file is no longer needed and should have been deleted in 56af04a.
bader
previously approved these changes
Feb 2, 2022
|
The changes here look good, but there's also a broken link to the PROPERTIES extension in https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/SYCL_EXT_ONEAPI_KERNEL_PROPERTIES.asciidoc. Would you mind fixing that in this PR? |
Thanks for pointing that out. Done in 3af54f7 |
Pennycook
approved these changes
Feb 4, 2022
bader
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two more documentation links. The links to
"PropertyList/SYCL_EXT_ONEAPI_property_list.asciidoc" were wrong even
before my recent reorg because the document used to be called
"SYCL_EXT_ONEAPI_properties.asciidoc". The links to
"StaticLocalMemoryQuery/SYCL_INTEL_static_local_memory_query" were
somehow missed from eb350ee.
The "USM/README.md" file is no longer needed and should have been
deleted in 56af04a.