[SYCL][DOC] Move experimental extension docs #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the experimental extensions to the "sycl/doc/extensions/experimental" directory, and add a README explaining the content of that directory. Each extension document has also been renamed to match the name of its feature-test macro. Links to these extensions have been removed from the table in "sycl/doc/extensions/README.md" because we want to avoid the possibility of that table getting out-of-date with the directory contents. Instead, users can see the list of experimental extensions by listing the content of the directory.
pvchupin
previously approved these changes
Jan 31, 2022
kbobrovs
previously approved these changes
Feb 1, 2022
|
I can do either way. Technically to enable merge button Required CI checks must pass and code owners approve. I have additional privileges for this this repository and can merge even if some requirements are not satisfied. |
mkinsner
approved these changes
Feb 1, 2022
|
Hi. I've noticed that some public doc links are not working after this change, e.g., like those found in esimd doc page, see the "specification" link. Not sure who is responsible for those. Just FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the experimental extensions to the
"sycl/doc/extensions/experimental" directory, and add a README
explaining the content of that directory. Each extension document has
also been renamed to match the name of its feature-test macro.
Links to these extensions have been removed from the table in
"sycl/doc/extensions/README.md" because we want to avoid the
possibility of that table getting out-of-date with the directory
contents. Instead, users can see the list of experimental extensions
by listing the content of the directory.