Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add XPTI instrumentation for SYCL buffer #5161

Merged
merged 13 commits into from
Dec 27, 2021
Merged

[SYCL] Add XPTI instrumentation for SYCL buffer #5161

merged 13 commits into from
Dec 27, 2021

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented Dec 16, 2021 •
edited
Loading

The change adds traces for SYCL buffers:

  • buffer or sub-buffer construction;
  • association of SYCL buffer with native memory handler;
  • release native memory handler;
  • buffer destruction.

E2E tests: intel/llvm-test-suite#681

@vladimirlaz vladimirlaz marked this pull request as draft December 16, 2021 17:23
@vladimirlaz vladimirlaz changed the title [SYCL] Add XTPI instrumentation for SYCL buffer [SYCL] Add XPTI instrumentation for SYCL buffer Dec 21, 2021
@vladimirlaz vladimirlaz marked this pull request as ready for review December 23, 2021 06:11
@vladimirlaz
[SYCL][XPTI] Improve buffer events
4c15962 
 - Add event for release native memory handle;
 - Add initial support for sub-buffers;
 - Revert buffer_impl layout change as breaking ABI;
 - Each event has unique ID now.
@vladimirlaz
Remove obsolete symbol
f9e7fce
@vladimirlaz vladimirlaz mentioned this pull request Dec 27, 2021
Merged
alexbatashev
alexbatashev previously approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sycl/source/detail/xpti_registry.cpp Show resolved Hide resolved
@vladimirlaz vladimirlaz merged commit 8f9d0d2 into intel:sycl Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

@andykaylor andykaylor Awaiting requested review from andykaylor

@bader bader Awaiting requested review from bader

@pvchupin pvchupin Awaiting requested review from pvchupin

@tovinkere tovinkere Awaiting requested review from tovinkere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimirlaz @alexbatashev