[WIP][SYCL] Align stream handling with other classes #2268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies FE handling of stream class and makes it identical to handling of accessor and sampler. Stream class is not handled as wrapper struct for several accessors and initialized within __init method.
Fznamznon
requested review from
againull,
elizabethandrews,
premanandrao and
a team
as code owners
Fznamznon
changed the title
|
@Fznamznon, what is plan for this PR? Are you going to commit this change? |
I'm going to finish it once I have a chance to work on it. |
erichkeane
reviewed
Apr 29, 2021
This one is pretty old and needs rebase. I guess @zahiraam just decided to create a new PR for it. |
|
Closing this PR in favor of #3646 |
jsji
pushed a commit
that referenced
this pull request
Jan 11, 2024
SPIRVEntry is created by function getEntry() but not deleted in a few frame ending branches. Original commit: KhronosGroup/SPIRV-LLVM-Translator@59f15de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies FE handling of stream class and makes it
identical to handling of accessor and sampler classes. Stream class is not
handled as wrapper struct for several accessors anymore and initialized
within __init method instead.
This is part of job about adding an attribute to annotate special sycl types
and unifying handling of sycl classes by FE. See #2091 (comment)
for the full idea.