[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero #2025

glyons-intel · 2020-07-01T14:58:45Z

Signed-off-by: Gail Lyons gail.lyons@intel.com

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

kbobrovs · 2020-07-01T23:51:21Z

sycl/source/detail/config.hpp

@@ -120,7 +120,7 @@ template <> class SYCLConfig<SYCL_BE> {
    const char *ValStr = BaseT::getRawValue();
    const std::array<std::pair<std::string, backend>, 3> SyclBeMap = {
        {{"PI_OPENCL", backend::opencl},
-         {"PI_LEVEL0", backend::level0},
+         {"PI_LEVEL0", backend::level_zero},


Suggested change

{"PI_LEVEL0", backend::level_zero},

{"PI_LEVEL_ZERO", backend::level_zero},

also docs which specify env variables need to be updated

smaslov-intel · 2020-07-02T05:53:01Z

sycl/source/detail/pi.cpp

@@ -215,7 +215,7 @@ bool findPlugins(vector_class<std::pair<std::string, backend>> &PluginNames) {
  // env only.
  //
  PluginNames.emplace_back(OPENCL_PLUGIN_NAME, backend::opencl);
-  PluginNames.emplace_back(LEVEL0_PLUGIN_NAME, backend::level0);
+  PluginNames.emplace_back(LEVEL0_PLUGIN_NAME, backend::level_zero);


LEVEL0_PLUGIN_NAME -> LEVEL_ZERO_PLUGIN_NAME

smaslov-intel · 2020-07-02T05:54:24Z

sycl/source/detail/program_manager/program_manager.cpp

@@ -766,7 +766,7 @@ ProgramManager::build(ProgramPtr Program, const ContextImplPtr Context,
  // is built during piProgramCreate.
  // TODO: remove this check as soon as piProgramCompile/piProgramLink will be
  // implemented in L0 plugin.


L0 -> Level-Zero, and please grep for other instances of "L0"

smaslov-intel · 2020-07-02T05:56:14Z

There are other instances of "Level0" and "L0" that need to be renamed, e.g. here:

CL/sycl/detail/pi.hpp:#define LEVEL0_PLUGIN_NAME "pi_level0.dll"
CL/sycl/detail/pi.hpp:#define LEVEL0_PLUGIN_NAME "libpi_level0.so"

smaslov-intel

Please rename more

SYCL_BE PI_LEVEL0 is now PI_LEVEL_ZERO. PI_LEVEL0 is still accepted and handled correctly. cl::sycl::backend::level0 is now cl::sycl::backend::level_zero. Signed-off-by: Gail Lyons <gail.lyons@intel.com>

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

smaslov-intel · 2020-07-14T13:31:56Z

sycl/plugins/level_zero/CMakeLists.txt


  # This script file is used to allow exporting pi* symbols only.
  # All other symbols are regarded as local (hidden)
  set(linker_script "${CMAKE_CURRENT_SOURCE_DIR}/../ld-version-script.txt")

  # Filter symbols based on the scope defined in the script file,
  # and export pi* function symbols in the library.
-  target_link_libraries( pi_level0
+  target_link_libraries( pi_level_zero
    PRIVATE "-Wl,--version-script=${linker_script}"
  )
 endif()

 if (TARGET l0-loader)


smaslov-intel · 2020-07-14T13:32:15Z

sycl/plugins/level_zero/CMakeLists.txt


-  target_link_libraries(pi_level0 PRIVATE "${L0_LOADER}")
+  target_link_libraries(pi_level_zero PRIVATE "${L0_LOADER}")


smaslov-intel · 2020-07-14T13:36:13Z

sycl/source/detail/config.hpp

         {"PI_CUDA", backend::cuda}}};
    if (ValStr) {
+      if (strcmp(ValStr, "PI_LEVEL0") == 0) {


Why did you want to support "PI_LEVEL0" name? Is this to accommodate current users/tests? Please add it to the array at line 123.

yes, for backwards compatibility. done.

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

smaslov-intel

LGTM

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

bader · 2020-07-22T15:48:20Z

sycl/test/abi/sycl_symbols_linux.dump

@@ -3724,7 +3728,9 @@ _ZN2cl4sycl6detail13MemoryManager13releaseMemObjESt10shared_ptrINS1_12context_im
 _ZN2cl4sycl6detail13MemoryManager16allocateMemImageESt10shared_ptrINS1_12context_implEEPNS1_11SYCLMemObjIEPvbmRK14_pi_image_descRK16_pi_image_formatRKS3_INS1_10event_implEERKS5_RP9_pi_event
 _ZN2cl4sycl6detail13MemoryManager17allocateMemBufferESt10shared_ptrINS1_12context_implEEPNS1_11SYCLMemObjIEPvbmRKS3_INS1_10event_implEERKS5_RP9_pi_event
 _ZN2cl4sycl6detail13MemoryManager18allocateHostMemoryEPNS1_11SYCLMemObjIEPvbm
+_ZN2cl4sycl6detail13MemoryManager18releaseImageBufferESt10shared_ptrINS1_12context_implEEPv


I guess we should bump SYCL library version.

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

bader

NOTE: SYCL version was incremented by other breaking changes already, so you need to update the version one more time.

sycl/source/detail/config.hpp

sycl/test/basic_tests/image_accessor_readsampler.cpp

sycl/test/spec_const/spec_const_hw.cpp

sycl/test/spec_const/spec_const_redefine.cpp

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

bader · 2020-07-29T07:55:16Z

@glyons-intel, it looks like there were other commits to the sycl branch, which conflict with this PR. Could you resolve conflicts, please?

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero

4dab89d

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel requested review from kbobrovs, smaslov-intel and a team as code owners July 1, 2020 14:58

kbobrovs suggested changes Jul 1, 2020

View reviewed changes

smaslov-intel reviewed Jul 2, 2020

View reviewed changes

smaslov-intel suggested changes Jul 2, 2020

View reviewed changes

glyons-intel added 3 commits July 13, 2020 12:02

Changed level0 -> level_zero.

9bf0ce1

SYCL_BE PI_LEVEL0 is now PI_LEVEL_ZERO. PI_LEVEL0 is still accepted and handled correctly. cl::sycl::backend::level0 is now cl::sycl::backend::level_zero. Signed-off-by: Gail Lyons <gail.lyons@intel.com>

Resolving merge conflicts.

eea2491

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

Resolving merge updates

91f729a

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel requested a review from pvchupin as a code owner July 14, 2020 12:44

smaslov-intel reviewed Jul 14, 2020

View reviewed changes

glyons-intel added 2 commits July 15, 2020 08:12

Incorporating code review comments

e96a951

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

Resolving merge conflicts

86f4ba3

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

smaslov-intel previously approved these changes Jul 16, 2020

View reviewed changes

Incorporating code review comments

f5083b2

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel dismissed smaslov-intel’s stale review via f5083b2 July 16, 2020 13:50

Merge remote-tracking branch 'upstream/sycl' into glyons-name

df201b1

smaslov-intel previously approved these changes Jul 16, 2020

View reviewed changes

glyons-intel added 2 commits July 17, 2020 05:16

Merge remote-tracking branch 'upstream/sycl' into glyons-name

4285c0d

Fixed clang-format issues

2bae103

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel dismissed smaslov-intel’s stale review via 2bae103 July 18, 2020 00:49

smaslov-intel previously approved these changes Jul 20, 2020

View reviewed changes

Resolving merge conflicts

accad53

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

bader reviewed Jul 22, 2020

View reviewed changes

Updated test files; bumped ABI version number

bc2b9ef

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel dismissed smaslov-intel’s stale review via bc2b9ef July 22, 2020 19:02

glyons-intel requested a review from smaslov-intel July 22, 2020 19:09

smaslov-intel previously approved these changes Jul 23, 2020

View reviewed changes

Resolving merge conflicts

7d2f600

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel dismissed smaslov-intel’s stale review via 7d2f600 July 24, 2020 19:05

Resolved clang-format issue.

2ab1e09

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

smaslov-intel previously approved these changes Jul 27, 2020

View reviewed changes

bader reviewed Jul 28, 2020

View reviewed changes

kbobrovs previously approved these changes Jul 28, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/sycl' into glyons-name

bceaeaf

pvchupin previously approved these changes Jul 28, 2020

View reviewed changes

Updated SYCL ABI version number. Addressed other code review comments.

c8479d3

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel dismissed stale reviews from pvchupin, kbobrovs, and smaslov-intel via c8479d3 July 28, 2020 15:49

bader self-assigned this Jul 28, 2020

smaslov-intel previously approved these changes Jul 28, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/sycl' into glyons-name

730b3f8

glyons-intel dismissed smaslov-intel’s stale review via 730b3f8 July 29, 2020 15:44

bader previously approved these changes Jul 29, 2020

View reviewed changes

glyons-intel added 2 commits July 29, 2020 10:14

Fixed merge conflict

1efcd0e

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

Resolving merge conflicts

10f75a4

Signed-off-by: Gail Lyons <gail.lyons@intel.com>

glyons-intel dismissed bader’s stale review via 10f75a4 July 30, 2020 13:14

bader approved these changes Jul 30, 2020

View reviewed changes

bader merged commit 215f591 into intel:sycl Jul 30, 2020

glyons-intel deleted the glyons-name branch October 28, 2020 19:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero #2025

[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero #2025

glyons-intel commented Jul 1, 2020

kbobrovs Jul 1, 2020

kbobrovs Jul 1, 2020

glyons-intel Jul 14, 2020

smaslov-intel Jul 2, 2020

glyons-intel Jul 14, 2020

smaslov-intel Jul 2, 2020

glyons-intel Jul 14, 2020

smaslov-intel commented Jul 2, 2020

smaslov-intel left a comment

smaslov-intel Jul 14, 2020

glyons-intel Jul 15, 2020

smaslov-intel Jul 14, 2020

glyons-intel Jul 15, 2020

smaslov-intel Jul 14, 2020

glyons-intel Jul 15, 2020

smaslov-intel left a comment

bader Jul 22, 2020

glyons-intel Jul 22, 2020

bader left a comment

bader commented Jul 29, 2020

	{"PI_LEVEL0", backend::level_zero},
	{"PI_LEVEL_ZERO", backend::level_zero},


		target_link_libraries(pi_level0 PRIVATE "${L0_LOADER}")
		target_link_libraries(pi_level_zero PRIVATE "${L0_LOADER}")

[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero #2025

[SYCL] Changed sycl::backend::level0 to sycl::backend::level_zero #2025

Conversation

glyons-intel commented Jul 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smaslov-intel commented Jul 2, 2020

smaslov-intel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smaslov-intel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bader left a comment

Choose a reason for hiding this comment

bader commented Jul 29, 2020