[SYCL][E2E] Introduce %{sycl_target_opts} substitution
#16614
Merged
+55
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
e2e_sycl_target_opts
branch
from
0c1419c to
5549c3e
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
e2e_sycl_target_opts
branch
from
5549c3e to
9e2d244
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
...and use it to pass `amd_arch` options to compilation only when compiling for AMD triples instead of unconditional usage in `%clangxx` substitution. That would avoid passing the option unnecessary when running `llvm-lit` with multiple target devices and a given test isn't supported for HIP. We might not have such configuration presently, but the same logic will be applied for "split" build/run of E2E tests and we'd definitely want to build tests for all the possible targets at once. Another use case for it is the "spirv backend" testing where we'd want to pass extra option for any compilations targeting spirv triple.
aelovikov-intel
force-pushed
the
e2e_sycl_target_opts
branch
from
9e2d244 to
3a2ea2a
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/syclcompat-lib-reviewers , ping. |
ProGTX
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and use it to pass
amd_archoptions to compilation only whencompiling for AMD triples instead of unconditional usage in
%clangxxsubstitution.
That would avoid passing the option unnecessary when running
llvm-litwith multiple target devices and a given test isn't supported for HIP.
We might not have such configuration presently, but the same logic will
be applied for "split" build/run of E2E tests and we'd definitely want
to build tests for all the possible targets at once.
Another use case for it is the "spirv backend" testing where we'd want
to pass extra option for any compilations targeting spirv triple.