Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Matrix] Add matrix combinations 16x16x16 and 32x64x16 bfloat16 for PVC #12026

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[SYCL][Matrix] Add matrix combinations 16x16x16 and 32x64x16 bfloat16 for PVC #12026

merged 2 commits into from
Nov 29, 2023

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Nov 28, 2023

No description provided.

@dkhaldi dkhaldi requested a review from a team as a code owner November 28, 2023 16:28
@dkhaldi dkhaldi changed the title [SYCL][Matrix] Add matrix combinations 16x16x16 and 32x64x16 for PVC [SYCL][Matrix] Add matrix combinations 16x16x16 and 32x64x16 bfloat16 for PVC Nov 28, 2023
dm-vodopyanov
dm-vodopyanov reviewed Nov 28, 2023
View reviewed changes
sycl/source/detail/device_info.hpp
@@ -763,6 +763,10 @@ struct get_device_info_impl<
matrix_type::fp32, matrix_type::fp32},
{8, 0, 0, 0, 16, 16, matrix_type::bf16, matrix_type::bf16,
matrix_type::fp32, matrix_type::fp32},
{0, 0, 0, 16, 16, 16, matrix_type::bf16, matrix_type::bf16,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Matrix/runtime_query_pvc.cpp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

dm-vodopyanov
dm-vodopyanov reviewed Nov 28, 2023
View reviewed changes
sycl/source/detail/device_info.hpp
@@ -763,6 +763,10 @@ struct get_device_info_impl<
matrix_type::fp32, matrix_type::fp32},
{8, 0, 0, 0, 16, 16, matrix_type::bf16, matrix_type::bf16,
matrix_type::fp32, matrix_type::fp32},
{0, 0, 0, 16, 16, 16, matrix_type::bf16, matrix_type::bf16,
matrix_type::fp32, matrix_type::fp32},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dkhaldi dkhaldi requested review from a team as code owners November 28, 2023 19:21
YuriPlyakhin
YuriPlyakhin approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmlueck
gmlueck approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec changes LGTM.

@YuriPlyakhin
Copy link
Contributor

@intel/llvm-gatekeepers, all green, please merge

@aelovikov-intel aelovikov-intel merged commit ff69048 into intel:sycl Nov 29, 2023
11 checks passed
@dkhaldi dkhaldi deleted the add-big-combin branch November 30, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin approved these changes

@gmlueck gmlueck gmlueck approved these changes

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkhaldi @YuriPlyakhin @gmlueck @dm-vodopyanov @aelovikov-intel