Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Remove trailing comment whitespace #11493

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Oct 10, 2023

Fixes post commit CI fail https://github.com/intel/llvm/actions/runs/6470268418/job/17566091513

/__w/llvm/llvm/src/sycl/unittests/Extensions/CommandGraph.cpp:1459:12: error: backslash and newline separated by space [-Werror,-Wbackslash-newline-escape]
 1459 |   //     /|\
      |            ^
1 error generated.

This was occuring due to a trailing whitespace character in the comment that was introduced in #11418 (comment)

Fixes post commit CI fail https://github.com/intel/llvm/actions/runs/6470268418/job/17566091513
```
/__w/llvm/llvm/src/sycl/unittests/Extensions/CommandGraph.cpp:1459:12: error: backslash and newline separated by space [-Werror,-Wbackslash-newline-escape]
 1459 |   //     /|\
      |            ^
1 error generated.
```

This was occuring due to a trailing whitespace character in the comment
that was introduced in intel#11418 (comment)
@EwanC EwanC requested a review from a team as a code owner October 10, 2023 17:10
@EwanC EwanC temporarily deployed to WindowsCILock October 10, 2023 17:11 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel merged commit 3b9ab90 into intel:sycl Oct 10, 2023
@aelovikov-intel
Copy link
Contributor

@intel/sycl-graphs-reviewers , please review post-commit.

@EwanC EwanC temporarily deployed to WindowsCILock October 10, 2023 17:36 — with GitHub Actions Inactive
@EwanC EwanC deleted the trailing_whitespace branch October 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants