Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Disable deferred buffer release for interop handle usage #11220

Merged
merged 5 commits into from
Oct 5, 2023
Merged

[SYCL] Disable deferred buffer release for interop handle usage #11220

merged 5 commits into from
Oct 5, 2023

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented Sep 19, 2023 •
edited
Loading

non-blocking buffer destructor could not be used with L0 interop handles with ownership "keep" since no way to distinguish when all resources is released by RT.

@KseniyaTikhomirova
[SYCL] Disable deferred buffer release for interop handle usage
559d658 
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova
add test
d345936 
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova
fix build
c204498 
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova
Add test
2a4e524 
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to WindowsCILock September 21, 2023 10:10 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to WindowsCILock September 25, 2023 11:05 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review September 25, 2023 14:18
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner September 25, 2023 14:18
@KseniyaTikhomirova
Copy link
Contributor Author

Failed Tests (1):
SYCL :: Graph/submission_while_executing.cpp

is unrelated, reported here #11277

@KseniyaTikhomirova
Copy link
Contributor Author

Failed Tests (1):
SYCL :: Graph/submission_while_executing.cpp

Testing Time: 2738.61s
Unsupported : 761
Passed : 918
Expectedly Failed: 26
Failed : 1

@KseniyaTikhomirova
Copy link
Contributor Author

failure is already reported here #11277

@KseniyaTikhomirova
Copy link
Contributor Author

@cperkinsintel kindly ping

@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to WindowsCILock September 27, 2023 12:23 — with GitHub Actions Inactive
@KseniyaTikhomirova KseniyaTikhomirova temporarily deployed to WindowsCILock September 27, 2023 12:47 — with GitHub Actions Inactive
cperkinsintel
cperkinsintel reviewed Sep 27, 2023
View reviewed changes
sycl/source/detail/context_impl.hpp
enum PropertySupport { NotSupported = 0, Supported = 1, NotChecked = 2 };

private:
bool MOwnedByRuntime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this name much better than "KeepOwnership" which was always confusing to me. Kept by whom?

Thanks!

@cperkinsintel
Copy link
Contributor

Since this is a test involving L0 ownership, shouldn't it have at least one E2E test?

cperkinsintel
cperkinsintel approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I do have a question about whether an E2E test is needed.

@KseniyaTikhomirova
Copy link
Contributor Author

Since this is a test involving L0 ownership, shouldn't it have at least one E2E test?

there is no way to check if destructor was blocking or not in E2E test. I could check this mechanism only via unittests.

@KseniyaTikhomirova
Copy link
Contributor Author

@cperkinsintel are you ok to merge it?

@KseniyaTikhomirova
Copy link
Contributor Author

@cperkinsintel kindly ping

@cperkinsintel
Copy link
Contributor

I'm Ok to merge it

@dm-vodopyanov dm-vodopyanov merged commit 171a311 into intel:sycl Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KseniyaTikhomirova @cperkinsintel @dm-vodopyanov