Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][NFC] Modernize getting host accessor #10224

Merged
merged 3 commits into from
Jul 6, 2023
Merged

[SYCL][NFC] Modernize getting host accessor #10224

merged 3 commits into from
Jul 6, 2023

Conversation

AlexeySachkov
Copy link
Contributor

get_access for host accessor is deprecated by SYCL 2020 in favor of get_host_access.

Note: this patch does not update all tests we have, there are still major categories skipped like XPTI, Sampler, etc.

@AlexeySachkov AlexeySachkov temporarily deployed to aws July 5, 2023 17:44 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov temporarily deployed to aws July 5, 2023 19:11 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov temporarily deployed to aws July 6, 2023 11:46 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov temporarily deployed to aws July 6, 2023 13:40 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov marked this pull request as ready for review July 6, 2023 14:16
@AlexeySachkov AlexeySachkov requested a review from a team as a code owner July 6, 2023 14:16
@AlexeySachkov
Copy link
Contributor Author

The only failed test on Windows couldn't be caused by the PR, because I only change tests and that failed test wasn't even touched:

********************
Failed Tests (1):
  SYCL :: ESIMD/api/functional/operators/operator_assignment_glb_mask.cpp

Moreover, based on logs it looks more like an infrastructure issue of sorts, because the test suddenly reports no available device after printing device name it has selected?

@AlexeySachkov AlexeySachkov merged commit 3dd16f6 into intel:sycl Jul 6, 2023
@Chenyang-L Chenyang-L mentioned this pull request Jul 11, 2023
Closed
@AlexeySachkov AlexeySachkov deleted the private/asachkov/modernize-get-access-use-in-lit branch May 22, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeySachkov @cperkinsintel