Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instructor-hub #1197

Merged
merged 13 commits into from
Nov 20, 2024
Merged

Remove instructor-hub #1197

merged 13 commits into from
Nov 20, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 19, 2024

This PR removes the instructor-hub functionality from the codebase as requested.

Changes:

  • Removed all hub-related files and directories
  • Added deprecated_hub.py with clear error messages
  • Updated documentation to remove hub references
  • Updated blog posts to point to new example locations
  • Removed hub CLI implementation
  • Added redirects in mkdocs.yml for hub pages

Link to Devin run: https://preview.devin.ai/devin/9d4024c8605e4648b54584d90b0217a2

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2024

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: 328a172
Status: ✅  Deploy successful!
Preview URL: https://62d6e778.instructor-py.pages.dev
Branch Preview URL: https://remove-instructor-hub.instructor-py.pages.dev

View logs

Copy link
Collaborator

@jxnl jxnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update the version please

mkdocs.yml Outdated Show resolved Hide resolved
- Removed instructor-hub-proxy directory
- Added redirects for hub documentation to examples
- Updated documentation links to point to new locations
- Added deprecated hub CLI command with error message
- Redirect all client-related hub pages to integrations/ instead of examples/
- Add legacy hub/clients/ redirects for backward compatibility
- Organize redirects into logical sections (clients, examples, etc.)
- Add proper type annotations for Typer usage
- Import specific types from typer module
- Fix Exit usage with proper type
- Add proper type annotations for Typer usage
- Import specific types from typer module
- Add Optional type for query parameter
- Add proper type annotations for CliRunner and Result
- Import specific types from typer module
- Add type hints for test variables
@jxnl jxnl requested a review from ivanleomk November 20, 2024 14:59
Copy link
Collaborator

@ivanleomk ivanleomk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks devin

@ivanleomk ivanleomk merged commit f0c9e4c into main Nov 20, 2024
14 of 15 checks passed
@ivanleomk ivanleomk deleted the remove-instructor-hub branch November 20, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants