-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove instructor-hub #1197
Merged
Merged
Remove instructor-hub #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying instructor-py with Cloudflare Pages
|
jxnl
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update the version please
devin-ai-integration
bot
force-pushed
the
remove-instructor-hub
branch
from
November 19, 2024 19:07
30db000
to
021327c
Compare
- Removed instructor-hub-proxy directory - Added redirects for hub documentation to examples - Updated documentation links to point to new locations - Added deprecated hub CLI command with error message
- Redirect all client-related hub pages to integrations/ instead of examples/ - Add legacy hub/clients/ redirects for backward compatibility - Organize redirects into logical sections (clients, examples, etc.)
- Add proper type annotations for Typer usage - Import specific types from typer module - Fix Exit usage with proper type
- Add proper type annotations for Typer usage - Import specific types from typer module - Add Optional type for query parameter
- Add proper type annotations for CliRunner and Result - Import specific types from typer module - Add type hints for test variables
ivanleomk
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks devin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the instructor-hub functionality from the codebase as requested.
Changes:
Link to Devin run: https://preview.devin.ai/devin/9d4024c8605e4648b54584d90b0217a2
If you have any feedback, you can leave comments in the PR and I'll address them in the app!