Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Collector
, a type that is composed by the same methods of Sensor, ot.Tracer and LeveledLogger, plus a few convenient methods. Collector is an implementation of the newly introducedTracerLogger
interface.It also deprecates
InitSensor
in favor ofStartMetrics
.Why
The name "sensor" is misleading. What our tracer provides is a tracer collector.
Our tracer communicates to the Go Sensor, which is a plugin of the Instana Agent.
As we cannot delete public APIs, we then deprecate Sensor in favor of using the collector. This will happen in future PRs.
Features
TracerLogger
.SensorLogger
is a small interface representing all non-deprecated methods fromSensor
TracerLogger
interface embedsTracer
andLeveledLogger
and the newly introducedSensorLogger
.Recorder
option is available. It's usually used for testing, so customers shouldn't worry about setting it.instana.StartMetrics
should be used in favor ofinstana.InitSensor
for better naming.